Make tabs example work on Windows and upgrade to StructOpt #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4859 +/- ##
===========================================
- Coverage 81.44% 39.11% -42.33%
===========================================
Files 61 159 +98
Lines 5782 12054 +6272
===========================================
+ Hits 4709 4715 +6
- Misses 1073 7339 +6266
Continue to review full report at Codecov.
|
mhammond
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabs example never worked on Windows or WSL, so I needed to fix that as part of the tabs persistence work, but thought I'd split it out. I'll also be adding another cmdline option, so figured I'd update to
StructOptat the same time to bring us in line with our other complex examples (eg, places_utils).CC @lougeniaC64 as she is also working with tabs at the moment.